Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add package dependencies #911

Merged
merged 9 commits into from
Dec 5, 2023

Conversation

joseivanlopez
Copy link
Contributor

@joseivanlopez joseivanlopez commented Dec 4, 2023

Problem

From time to time an issue is reported because some missing dependency in the Agama live image (many times related to missing storage packages). Moreover, Agama depencencies are directly added to the ISO kiwi file, forcing to all our live images to include that list of packages. Agama should requires its own dependencies instead on relying on the live iso to provide them.

Solution

Notes:

  • Right now both the setup scripts and the spec files contain almost the same list of packages. They should be unified.
  • For CI tasks not all dependencies are installed, but only the required dependencies for running the tasks (e.g., unit tests).
  • Agama live imagein IBS is not updated. It will be done when submitting a new Agama version to IBS.

@coveralls
Copy link

coveralls commented Dec 4, 2023

Coverage Status

coverage: 75.019% (-0.006%) from 75.025%
when pulling ccb3f34 on joseivanlopez:dependencies
into 7903c82 on openSUSE:master.

@joseivanlopez joseivanlopez marked this pull request as ready for review December 4, 2023 16:08
Copy link
Contributor

@imobachgs imobachgs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I only have two comments but, otherwise, it looks great.

setup-services.sh Outdated Show resolved Hide resolved
setup-services.sh Outdated Show resolved Hide resolved
@joseivanlopez joseivanlopez merged commit 2c46c58 into agama-project:master Dec 5, 2023
2 checks passed
@imobachgs imobachgs mentioned this pull request Feb 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants